fix(backend): correct amortization schedule and total due interest ca… - #1575
Merged
ogazboiz merged 2 commits intoAug 3, 2026
Merged
Conversation
…lculation (LabsCrypt#1371) Ensure total due and total owed include accrued interest instead of subtracting it in backend/src/controllers/loanController.ts (buildAmortizationSchedule & getLoanDetails).
ogazboiz
approved these changes
Aug 3, 2026
ogazboiz
left a comment
ogazboiz
left a comment
Contributor
There was a problem hiding this comment.
good work. the totalOwed fix (accrued interest added instead of subtracted) is correct and the two regression assertions are exactly the guards we want. note the buildAmortizationSchedule half of #1371 had already landed on main, so this effectively closes #1369 with test coverage for both identities. CI green after rebase. merging.
if you want to keep contributing, join us on Telegram: https://t.me/+DOylgFv1jyJlNzM0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1371
Fixes #1371 — amortization total due was understated by all interest.
backend/src/controllers/loanController.ts: fixedgetLoanDetailstotalOwedtoprincipal + accruedInterest - totalRepaid, and ensuredbuildAmortizationSchedulereturnstotalDue = principal + totalInterestbackend/src/__tests__/loanEndpoints.test.ts: added regression assertions fortotalOwedand amortizationtotalDueVerification:
npm run typecheck✅,npm test✅,npm run build✅.